test_ita_calendar_book_flow.py 44 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949
  1. import copy
  2. import json
  3. import shutil
  4. import subprocess
  5. import traceback
  6. import unittest
  7. from contextlib import contextmanager
  8. from datetime import date, datetime
  9. from unittest.mock import Mock, patch
  10. from plugins import ita_plugin as book_calendar
  11. from plugins.ita_plugin import (
  12. DATE_SELECTION_SCRIPT, SLOT_SELECTION_SCRIPT, TIME_SLOTS_PATH,
  13. CalendarBookError, book_date_preferences, recheck_calendar_before_final,
  14. )
  15. from plugins.ita_plugin import AVAILABILITY_PATH, CalendarNextMonthUnavailableError
  16. from plugins.ita_plugin import (
  17. BOOKING_CALENDAR_PREFINAL_STOP_LABEL, BOOKING_RECHECK_NONE_AVAILABLE_LABEL, ItaPlugin,
  18. )
  19. from test.ita.test_ita_calendar_book import FakePage, SERVICE, packet
  20. from test.ita import test_ita_plugin as plugin_fixtures
  21. from test.ita.test_ita_protocol import availability_item, slot_item
  22. from vs_types import (
  23. AppointmentType, BizLogicError, DateAvailability, RateLimiteddError,
  24. SessionExpiredOrInvalidError, TimeSlot, VSAccount, VSPlgConfig, VSQueryResult,
  25. )
  26. def month(value, inventory, *, automatic_day=None, slots=None):
  27. """Synthetic inventory only; IDs and accounts below never leave the tests."""
  28. return {"month": value, "inventory": inventory, "automatic_day": automatic_day,
  29. "slots": slots or {}}
  30. def positive_month():
  31. return month("2026-10", {13: 1})
  32. class FakeListener:
  33. def __init__(self, page):
  34. self.page = page
  35. self.queue = []
  36. self.listening = False
  37. self.starts = 0
  38. self.stops = 0
  39. self.target = None
  40. def start(self, targets, method):
  41. self.starts += 1
  42. self.target = targets
  43. self.queue.clear() # Matches the installed Listener.start contract.
  44. self.listening = True
  45. self.page.events.append("listen-start")
  46. if method != "POST":
  47. raise AssertionError("Unexpected listener method")
  48. def wait(self, timeout, raise_err=False):
  49. if not self.listening:
  50. raise AssertionError("Wait without listener")
  51. if self.page.wait_hook:
  52. self.page.wait_hook()
  53. if not self.queue:
  54. return False
  55. result = self.queue.pop(0)
  56. if result.url.endswith(TIME_SLOTS_PATH):
  57. self.page.selected_day = getattr(result, "fixture_day", None)
  58. self.page.content_day = self.page.render_day or self.page.selected_day
  59. self.page.current_slots = getattr(result, "fixture_slots", [])
  60. self.page.active = False
  61. return result
  62. def stop(self):
  63. self.stops += 1
  64. self.queue.clear()
  65. self.listening = False
  66. self.page.events.append("listen-stop")
  67. class FlowPage(FakePage):
  68. def __init__(self, months=None, *, passes=None):
  69. super().__init__()
  70. self.tab_id = "book-tab"
  71. self.listen = FakeListener(self)
  72. self.wait = Mock()
  73. self.quit = Mock()
  74. self.passes = passes or [months or [positive_month()]]
  75. self.refreshes = 0
  76. self.month_index = 0
  77. self.month_spec = self.passes[0][0]
  78. self.selected_day = None
  79. self.content_day = None
  80. self.current_slots = []
  81. self.date_clicks = []
  82. self.month_clicks = 0
  83. self.requests = []
  84. self.request_mutator = None
  85. self.wait_hook = None
  86. self.render_day = None
  87. self.reverse_responses = False
  88. self.drop_automatic = False
  89. self.duplicate_availability = False
  90. self.date_ack = True
  91. self.date_candidate_count = None
  92. self.date_enabled = True
  93. self.date_runtime_matches = True
  94. def response_packet(self, path, body, items, day=None):
  95. result = packet(path, body, items)
  96. result.tab_id = self.tab_id
  97. result.is_failed = False
  98. result.fixture_day = day
  99. result.fixture_slots = items
  100. if self.request_mutator:
  101. self.request_mutator(result)
  102. self.requests.append(result)
  103. return result
  104. def times_packet(self, day):
  105. number = int(day[-2:])
  106. free = self.month_spec["slots"].get(number, self.month_spec["inventory"].get(number, 0))
  107. day_value = date.fromisoformat(day)
  108. items = [slot_item(day_value.strftime("%d/%m/%Y 00:00:00"), (10, 5), (11, 5),
  109. free, free - 1, 80000000 + self.refreshes * 100 + number)]
  110. return self.response_packet(TIME_SLOTS_PATH, {"selectedDay": day, "idService": SERVICE}, items, day)
  111. def load_month(self):
  112. self.selected_day = self.content_day = None
  113. value = self.month_spec["month"]
  114. inventory = self.month_spec["inventory"]
  115. items = [availability_item(date.fromisoformat(f"{value}-{day:02d}").strftime("%d/%m/%Y 00:00:00"),
  116. free, free - 1) for day, free in inventory.items()]
  117. availability = self.response_packet(
  118. AVAILABILITY_PATH,
  119. {"_Servizio": "calendar-runtime-key", "selectedDay": f"{value}-01"}, items,
  120. )
  121. responses = [availability]
  122. if self.duplicate_availability:
  123. responses.append(availability)
  124. elif inventory and not self.drop_automatic:
  125. auto = self.month_spec["automatic_day"] or min(inventory)
  126. responses.append(self.times_packet(f"{value}-{auto:02d}"))
  127. if self.reverse_responses:
  128. responses.reverse()
  129. self.listen.queue.extend(responses)
  130. def refresh(self):
  131. self.refreshes += 1
  132. self.month_index = 0
  133. self.month_spec = self.passes[min(self.refreshes - 1, len(self.passes) - 1)][0]
  134. self.events.append("refresh")
  135. self.load_month()
  136. def next_month(self):
  137. self.month_clicks += 1
  138. self.month_index += 1
  139. sequence = self.passes[min(self.refreshes - 1, len(self.passes) - 1)]
  140. if self.month_index >= len(sequence):
  141. raise CalendarNextMonthUnavailableError("No next month in fixture")
  142. self.month_spec = sequence[self.month_index]
  143. self.events.append("next-month")
  144. self.load_month()
  145. def run_js(self, script, *args):
  146. if script == DATE_SELECTION_SCRIPT:
  147. service, day, click = args
  148. count = int(day[:7] == self.month_spec["month"] and int(day[-2:]) in self.month_spec["inventory"])
  149. if self.date_candidate_count is not None:
  150. count = self.date_candidate_count
  151. selected = day == self.selected_day == self.content_day
  152. context = self.date_runtime_matches and service == self.service
  153. ready = context and count == 1 and self.date_enabled
  154. clicked = bool(click and self.date_ack and ready and not selected)
  155. raw = {"contextReady": context, "candidateCount": count,
  156. "candidateReady": ready, "selected": context and count == 1 and selected,
  157. "clicked": clicked}
  158. if clicked:
  159. self.date_clicks.append(day)
  160. self.events.append("date-click")
  161. self.listen.queue.append(self.times_packet(day))
  162. return raw
  163. raw = super().run_js(script, *args)
  164. if script == SLOT_SELECTION_SCRIPT:
  165. _, day, daily_id, label, free, _ = args
  166. matching = [item for item in self.current_slots
  167. if str(item["IDCalendarioServizioGiornaliero"]) == daily_id]
  168. raw["contextReady"] = raw["contextReady"] and day == self.selected_day == self.content_day
  169. raw["candidateCount"] = len(matching)
  170. raw["candidateReady"] = (raw["contextReady"] and len(matching) == 1
  171. and matching[0]["SlotLiberi"] == free)
  172. raw["selected"] = raw["candidateReady"] and self.active
  173. raw.update(self.after_overrides if self.clicks else {})
  174. return raw
  175. @contextmanager
  176. def browser_navigation(page):
  177. original_click = book_calendar.click_next_month
  178. # Query and Book now share this function's module. Only intercept the
  179. # synthetic Book page; concurrent Query keeps its own native adapter.
  180. with patch.object(book_calendar, "click_next_month", side_effect=lambda actual:
  181. page.next_month() if actual is page else original_click(actual)), \
  182. patch.object(book_calendar.time, "sleep"):
  183. yield
  184. def book_with_approval(plugin, trigger, inputs, *, call=None):
  185. captured = []
  186. original = book_calendar.recheck_calendar_before_final
  187. def observe(*args, **kwargs):
  188. approval = original(*args, **kwargs)
  189. captured.append(approval)
  190. return approval
  191. with patch.object(book_calendar, "recheck_calendar_before_final", side_effect=observe):
  192. result = (call or plugin.book)(trigger, inputs)
  193. return result, captured[0] if captured else None
  194. def run_flow(page, **kwargs):
  195. options = dict(lookahead_months=3, start_day=date(2026, 8, 1), end_day=date(2026, 12, 31),
  196. session_is_current=lambda: True, month_click_interval_seconds=0, dom_timeout=0)
  197. options.update(kwargs)
  198. with browser_navigation(page):
  199. return recheck_calendar_before_final(page, **options)
  200. class BookCalendarFlowTests(unittest.TestCase):
  201. def assert_stopped(self, page):
  202. self.assertFalse(page.listen.listening)
  203. self.assertEqual(page.listen.starts, page.listen.stops)
  204. def test_refresh_waits_for_runtime_reassignment_without_repeating_refresh(self):
  205. page = FlowPage()
  206. original_run_js = page.run_js
  207. pending_reads = []
  208. def delayed(script, *args):
  209. result = original_run_js(script, *args)
  210. if script == book_calendar.RUNTIME_SERVICE_SCRIPT and page.refreshes:
  211. pending_reads.append(True)
  212. if len(pending_reads) == 1:
  213. return {**result, "value": ""}
  214. return result
  215. page.run_js = delayed
  216. self.assertIsNotNone(run_flow(page, dom_timeout=1))
  217. self.assertEqual(page.refreshes, 1)
  218. self.assertEqual(page.clicks, 1)
  219. self.assertEqual(len(page.requests), 2)
  220. self.assert_stopped(page)
  221. def test_empty_after_refresh_times_out_without_selecting_or_refreshing_again(self):
  222. page = FlowPage()
  223. original_refresh = page.refresh
  224. def empty_refresh():
  225. original_refresh()
  226. page.service = ""
  227. page.refresh = empty_refresh
  228. with self.assertRaises(book_calendar.CalendarServiceNotReadyError):
  229. run_flow(page)
  230. self.assertEqual(page.refreshes, 1)
  231. self.assertEqual(page.clicks, 0)
  232. self.assert_stopped(page)
  233. def test_automatic_positive_day_uses_fresh_response_without_date_click(self):
  234. page = FlowPage()
  235. result = run_flow(page)
  236. self.assertEqual(result.candidate.day, date(2026, 10, 13))
  237. self.assertEqual(result.candidate.daily_calendar_id, "80000113")
  238. self.assertEqual(page.refreshes, 1)
  239. self.assertEqual(page.date_clicks, [])
  240. self.assertEqual(page.clicks, 1)
  241. self.assertEqual(len(page.requests), 2)
  242. self.assert_stopped(page)
  243. def test_native_date_click_is_followed_by_current_time_slots(self):
  244. page = FlowPage([month("2026-10", {1: 0, 13: 1})])
  245. result = run_flow(page)
  246. self.assertEqual(result.candidate.day, date(2026, 10, 13))
  247. self.assertEqual(page.date_clicks, ["2026-10-13"])
  248. self.assertEqual(page.listen.starts, 2)
  249. self.assertEqual(len(page.requests), 3)
  250. self.assert_stopped(page)
  251. def test_each_captured_inventory_response_is_parsed_once(self):
  252. for inventory in ({13: 1}, {1: 0, 13: 1}):
  253. with self.subTest(inventory=inventory):
  254. page = FlowPage([month("2026-10", inventory)])
  255. with patch.object(book_calendar, "parse_availability_packet",
  256. wraps=book_calendar.parse_availability_packet) as availability_parser, \
  257. patch.object(book_calendar, "parse_book_time_slots",
  258. wraps=book_calendar.parse_book_time_slots) as slots_parser:
  259. self.assertIsNotNone(run_flow(page))
  260. self.assertEqual(availability_parser.call_count,
  261. sum(p.url.endswith(AVAILABILITY_PATH) for p in page.requests))
  262. self.assertEqual(slots_parser.call_count,
  263. sum(p.url.endswith(TIME_SLOTS_PATH) for p in page.requests))
  264. self.assertEqual(page.clicks, 1)
  265. self.assert_stopped(page)
  266. def test_candidate_is_filtered_once_while_waiting_for_delayed_dom(self):
  267. page = FlowPage()
  268. original = page.run_js
  269. slot_reads = []
  270. clock = [0.0]
  271. def delayed(script, *args):
  272. raw = original(script, *args)
  273. if script == SLOT_SELECTION_SCRIPT:
  274. slot_reads.append(args[-1])
  275. if len(slot_reads) <= 2:
  276. raw.update(candidateReady=False, candidateCount=0)
  277. return raw
  278. page.run_js = delayed
  279. with browser_navigation(page), \
  280. patch.object(book_calendar.time, "monotonic", side_effect=lambda: clock[0]), \
  281. patch.object(book_calendar.time, "sleep", side_effect=lambda delay: clock.__setitem__(0, clock[0] + delay)), \
  282. patch.object(book_calendar, "available_slot_candidates", wraps=book_calendar.available_slot_candidates) as select_candidates:
  283. result = recheck_calendar_before_final(
  284. page, lookahead_months=1, start_day=date(2026, 10, 1), end_day=date(2026, 10, 31),
  285. session_is_current=lambda: True, dom_timeout=0.5,
  286. )
  287. self.assertIsNotNone(result)
  288. self.assertEqual(select_candidates.call_count, 1)
  289. self.assertEqual(slot_reads, [False, False, False, True, False])
  290. self.assertEqual(page.clicks, 1)
  291. self.assertEqual(page.refreshes, 1)
  292. self.assertEqual(len(page.requests), 2)
  293. self.assert_stopped(page)
  294. def test_delayed_slot_timeout_is_bounded_without_extra_request_or_click(self):
  295. page = FlowPage()
  296. original = page.run_js
  297. clock = [0.0]
  298. def missing_slot(script, *args):
  299. raw = original(script, *args)
  300. if script == SLOT_SELECTION_SCRIPT:
  301. raw.update(candidateReady=False, candidateCount=0)
  302. return raw
  303. page.run_js = missing_slot
  304. with browser_navigation(page), \
  305. patch.object(book_calendar.time, "monotonic", side_effect=lambda: clock[0]), \
  306. patch.object(book_calendar.time, "sleep", side_effect=lambda delay: clock.__setitem__(0, clock[0] + delay)), \
  307. self.assertRaisesRegex(CalendarBookError, "slot DOM did not match"):
  308. recheck_calendar_before_final(
  309. page, lookahead_months=1, start_day=date(2026, 10, 1), end_day=date(2026, 10, 31),
  310. session_is_current=lambda: True, dom_timeout=0.25,
  311. )
  312. self.assertAlmostEqual(clock[0], 0.25)
  313. self.assertEqual(page.clicks, 0)
  314. self.assertEqual(page.refreshes, 1)
  315. self.assertEqual(len(page.requests), 2)
  316. self.assert_stopped(page)
  317. def test_old_listener_queue_is_cleared_before_month_action(self):
  318. page = FlowPage()
  319. stale = packet(TIME_SLOTS_PATH, {}, [])
  320. stale.tab_id = "query-tab"
  321. page.listen.queue.append(stale)
  322. result = run_flow(page)
  323. self.assertIsNotNone(result)
  324. self.assertIsNot(page.requests[-1], stale)
  325. def test_can_collect_automatic_response_before_availability_delivery(self):
  326. page = FlowPage()
  327. page.reverse_responses = True
  328. self.assertIsNotNone(run_flow(page))
  329. self.assertEqual(page.date_clicks, [])
  330. def test_cross_year_scan_stops_at_first_usable_day(self):
  331. page = FlowPage([month("2026-12", {1: 0}), month("2027-01", {5: 1}), month("2027-02", {1: 4})])
  332. result = run_flow(page, end_day=date(2027, 3, 1))
  333. self.assertEqual(result.candidate.day, date(2027, 1, 5))
  334. self.assertEqual(page.month_clicks, 1)
  335. def test_applies_inclusive_preferences_even_if_earlier_month_is_positive(self):
  336. page = FlowPage([month("2026-09", {1: 2}), month("2026-10", {12: 2, 13: 1, 14: 3})])
  337. result = run_flow(page, start_day=date(2026, 10, 13), end_day=date(2026, 10, 13))
  338. self.assertEqual(result.candidate.day, date(2026, 10, 13))
  339. self.assertEqual(page.date_clicks, ["2026-10-13"])
  340. self.assertEqual(page.month_clicks, 1)
  341. def test_date_inventory_race_tries_next_day_without_repeating_failed_candidate(self):
  342. page = FlowPage([month("2026-10", {13: 1, 14: 2}, slots={13: 0})])
  343. result = run_flow(page)
  344. self.assertEqual(result.candidate.day, date(2026, 10, 14))
  345. self.assertEqual(page.date_clicks, ["2026-10-14"])
  346. self.assertEqual(page.clicks, 1)
  347. def test_later_automatic_day_is_recaptured_after_another_date_was_selected(self):
  348. page = FlowPage([month("2026-10", {13: 1, 14: 1}, automatic_day=14, slots={13: 0})])
  349. result = run_flow(page)
  350. self.assertEqual(result.candidate.day, date(2026, 10, 14))
  351. self.assertEqual(page.date_clicks, ["2026-10-13", "2026-10-14"])
  352. def test_scans_applicant_inventory_once_in_chronological_order(self):
  353. page = FlowPage([month("2026-09", {9: 2}), month("2026-10", {13: 1})])
  354. result = run_flow(page)
  355. self.assertEqual(result.candidate.day, date(2026, 9, 9))
  356. self.assertEqual(page.refreshes, 1)
  357. self.assertEqual(page.month_clicks, 0)
  358. def test_full_negative_horizon_returns_none_without_slot_clicks(self):
  359. page = FlowPage([month("2026-08", {1: 0}), month("2026-09", {}), month("2026-10", {1: 0})])
  360. self.assertIsNone(run_flow(page))
  361. self.assertEqual(page.month_clicks, 2)
  362. self.assertEqual(page.date_clicks, [])
  363. self.assertEqual(page.clicks, 0)
  364. self.assert_stopped(page)
  365. def test_no_month_beyond_user_end_is_requested(self):
  366. page = FlowPage([month("2026-10", {1: 0})])
  367. self.assertIsNone(run_flow(page, end_day=date(2026, 10, 31)))
  368. self.assertEqual(page.month_clicks, 0)
  369. def test_missing_next_month_is_an_error_not_no_inventory(self):
  370. page = FlowPage([month("2026-10", {})])
  371. with self.assertRaises(CalendarBookError):
  372. run_flow(page)
  373. self.assert_stopped(page)
  374. def test_month_jump_is_rejected(self):
  375. page = FlowPage([month("2026-08", {}), month("2026-10", {13: 1})])
  376. with self.assertRaisesRegex(CalendarBookError, "exactly one month"):
  377. run_flow(page)
  378. self.assertEqual(page.clicks, 0)
  379. self.assert_stopped(page)
  380. def test_bad_packet_metadata_is_never_used_or_retried(self):
  381. mutations = [
  382. lambda p: setattr(p, "tab_id", "query-tab"),
  383. lambda p: setattr(p, "is_failed", True),
  384. lambda p: setattr(p, "url", "https://other.example.test" + AVAILABILITY_PATH),
  385. lambda p: setattr(p, "method", "GET"),
  386. lambda p: setattr(p.response, "status", 429),
  387. lambda p: p.request.postData.update(_Servizio=None),
  388. ]
  389. for mutate in mutations:
  390. with self.subTest(mutation=mutations.index(mutate)):
  391. page = FlowPage()
  392. page.request_mutator = mutate
  393. with self.assertRaises(CalendarBookError):
  394. run_flow(page)
  395. self.assertEqual(page.refreshes, 1)
  396. self.assertEqual(page.clicks, 0)
  397. self.assert_stopped(page)
  398. def test_time_slots_from_wrong_date_or_service_fail(self):
  399. for field, value in (("selectedDay", "2026-10-14"), ("idService", "wrong-service")):
  400. page = FlowPage()
  401. page.request_mutator = lambda p: p.request.postData.update({field: value}) if p.url.endswith(TIME_SLOTS_PATH) else None
  402. with self.subTest(field=field), self.assertRaises(CalendarBookError):
  403. run_flow(page)
  404. self.assertEqual(page.clicks, 0)
  405. self.assert_stopped(page)
  406. def test_date_click_response_is_bound_to_that_day_and_tab(self):
  407. for field in ("tab", "day"):
  408. with self.subTest(field=field):
  409. page = FlowPage([month("2026-10", {1: 0, 13: 1})])
  410. def corrupt_after_click(result):
  411. if not page.date_clicks:
  412. return
  413. if field == "tab":
  414. result.tab_id = "old-query-tab"
  415. else:
  416. result.request.postData["selectedDay"] = "2026-10-01"
  417. page.request_mutator = corrupt_after_click
  418. with self.assertRaises(CalendarBookError):
  419. run_flow(page)
  420. self.assertEqual(page.date_clicks, ["2026-10-13"])
  421. self.assertEqual(page.clicks, 0)
  422. self.assert_stopped(page)
  423. def test_availability_service_must_remain_same_across_months(self):
  424. page = FlowPage([month("2026-09", {}), positive_month()])
  425. page.request_mutator = lambda p: p.request.postData.update(_Servizio="changed") if page.month_clicks and p.url.endswith(AVAILABILITY_PATH) else None
  426. with self.assertRaisesRegex(CalendarBookError, "runtime service changed"):
  427. run_flow(page)
  428. def test_missing_automatic_response_and_duplicate_month_stop_listener(self):
  429. for option in ("drop_automatic", "duplicate_availability"):
  430. with self.subTest(option=option):
  431. page = FlowPage()
  432. setattr(page, option, True)
  433. with self.assertRaises(CalendarBookError):
  434. run_flow(page)
  435. self.assertEqual(page.date_clicks, [])
  436. self.assert_stopped(page)
  437. def test_negative_availability_but_positive_auto_slot_is_conflict(self):
  438. page = FlowPage([month("2026-10", {13: 0}, slots={13: 1})])
  439. with self.assertRaisesRegex(CalendarBookError, "disagree"):
  440. run_flow(page)
  441. self.assertEqual(page.clicks, 0)
  442. def test_site_date_fallback_does_not_select_wrong_day(self):
  443. page = FlowPage()
  444. page.render_day = "2026-10-01"
  445. with self.assertRaisesRegex(CalendarBookError, "selected date"):
  446. run_flow(page)
  447. self.assertEqual(page.clicks, 0)
  448. self.assert_stopped(page)
  449. def test_failed_date_click_is_not_retried(self):
  450. page = FlowPage([month("2026-10", {1: 0, 13: 1})])
  451. page.date_ack = False
  452. with self.assertRaisesRegex(CalendarBookError, "acknowledged"):
  453. run_flow(page)
  454. self.assertEqual(page.date_clicks, [])
  455. self.assert_stopped(page)
  456. def test_bad_date_control_is_rejected_without_click(self):
  457. for field, value in (("date_candidate_count", 2), ("date_enabled", False),
  458. ("date_runtime_matches", False)):
  459. with self.subTest(field=field):
  460. page = FlowPage([month("2026-10", {1: 0, 13: 1})])
  461. setattr(page, field, value)
  462. with self.assertRaises(CalendarBookError):
  463. run_flow(page)
  464. self.assertEqual(page.date_clicks, [])
  465. self.assert_stopped(page)
  466. def test_post_slot_click_error_stops_without_trying_another_day(self):
  467. page = FlowPage([month("2026-10", {13: 1, 14: 2})])
  468. page.after_overrides = {"selected": False}
  469. with self.assertRaises(CalendarBookError):
  470. run_flow(page)
  471. self.assertEqual(page.clicks, 1)
  472. self.assertEqual(page.date_clicks, [])
  473. def test_context_invalid_before_or_during_capture_blocks_selection(self):
  474. page = FlowPage()
  475. with self.assertRaises(CalendarBookError):
  476. run_flow(page, session_is_current=lambda: False)
  477. self.assertEqual(page.refreshes, 0)
  478. current = [True]
  479. page = FlowPage()
  480. page.wait_hook = lambda: current.__setitem__(0, False)
  481. with self.assertRaises(CalendarBookError):
  482. run_flow(page, session_is_current=lambda: current[0])
  483. self.assertEqual(page.clicks, 0)
  484. self.assert_stopped(page)
  485. def test_invalid_settings_do_not_navigate(self):
  486. for kwargs in ({"lookahead_months": True}, {"lookahead_months": 0},
  487. {"start_day": None}, {"end_day": date(2025, 1, 1)},
  488. {"timeout": 0},
  489. {"timeout": float("nan")}, {"dom_timeout": -1}):
  490. with self.subTest(kwargs=kwargs):
  491. page = FlowPage()
  492. with self.assertRaises(CalendarBookError):
  493. run_flow(page, **kwargs)
  494. self.assertEqual(page.refreshes, 0)
  495. def test_provider_error_does_not_leak_raw_body(self):
  496. page = FlowPage()
  497. page.wait_hook = Mock(side_effect=RuntimeError("secret-response-body"))
  498. try:
  499. run_flow(page)
  500. except CalendarBookError:
  501. self.assertNotIn("secret-response-body", traceback.format_exc())
  502. else:
  503. self.fail("Provider error was accepted")
  504. self.assert_stopped(page)
  505. class BookPreferenceTests(unittest.TestCase):
  506. def test_uses_existing_keys_and_does_not_mutate_inputs(self):
  507. values = {"expected_start_date": "2026-10-13", "expected_end_date": "2026-10-13", "other": "keep"}
  508. before = copy.deepcopy(values)
  509. self.assertEqual(book_date_preferences(values), (date(2026, 10, 13), date(2026, 10, 13)))
  510. self.assertEqual(values, before)
  511. self.assertEqual(book_date_preferences({}), (date(2000, 1, 1), date(2100, 1, 1)))
  512. def test_rejects_unknown_formats_and_inverted_range(self):
  513. for values in (None, {"expected_start_date": None}, {"expected_start_date": "20261013"},
  514. {"expected_start_date": "2026-02-30"}, {"expected_start_date": "secret-input"},
  515. {"expected_start_date": "2026-10-14", "expected_end_date": "2026-10-13"}):
  516. with self.subTest(values=values), self.assertRaises(CalendarBookError) as raised:
  517. book_date_preferences(values)
  518. self.assertNotIn("secret-input", str(raised.exception))
  519. def prepared_plugin(page, *, routing_key="slot.example.it.tourist"):
  520. plugin = plugin_fixtures.ItaPluginQuerySafetyTests._plugin(
  521. page, routing_key=routing_key, service_id=9001,
  522. capability="single_schengen_tourism", lookahead_months=3,
  523. )
  524. plugin.config = VSPlgConfig(account=VSAccount(username="applicant@example.test"), free_config=plugin.free_config)
  525. plugin.instance_id = "book-offline"
  526. plugin.session_create_time = 111.0
  527. plugin.user_data_path = "/nonexistent/ita-book-flow-test"
  528. plugin._reset_calendar_state()
  529. route = plugin._resolve_route(AppointmentType(routing_key=routing_key))
  530. plugin._record_calendar_prepared_route(route, role="book")
  531. plugin.query = Mock(side_effect=AssertionError("Calendar Book must not call Query"))
  532. trigger = VSQueryResult(apt_type=AppointmentType(routing_key=routing_key))
  533. return plugin, route, trigger
  534. class BookEntryTests(unittest.TestCase):
  535. def test_query_and_book_share_month_reader_but_not_account_inventory(self):
  536. from test.ita.test_debug_ita_production_query_gate import FakeProductionPage, make_plugin
  537. query_page = FakeProductionPage([[(2026, 9, ()), (2026, 10, (13,))]])
  538. query, query_route = make_plugin(query_page)
  539. query.free_config["query_mode"] = "calendar"
  540. book_page = FlowPage([month("2026-10", {13: 0, 14: 1})])
  541. applicant, _, _ = prepared_plugin(book_page, routing_key=query_route.routing_key)
  542. with browser_navigation(book_page), patch.object(
  543. book_calendar, "_capture_month", wraps=book_calendar._capture_month
  544. ) as capture:
  545. signal = query.query(query_route.appointment_type())
  546. result, approval = book_with_approval(
  547. applicant, signal, {"username": "applicant@example.test"},
  548. )
  549. self.assertTrue(signal.success)
  550. self.assertEqual(signal.earliest_date, datetime(2026, 10, 13))
  551. self.assertFalse(result.success) # Pre-final selection is not a booking.
  552. self.assertEqual(result.label, BOOKING_CALENDAR_PREFINAL_STOP_LABEL)
  553. self.assertEqual(approval.candidate.day, date(2026, 10, 14))
  554. self.assertNotEqual(query.config.account.username, applicant.config.account.username)
  555. self.assertEqual([call.args[0] for call in capture.call_args_list],
  556. [query_page, query_page, book_page])
  557. self.assertTrue(all(call.kwargs.get("service") is None for call in capture.call_args_list[:2]))
  558. self.assertEqual(capture.call_args_list[2].kwargs["service"], SERVICE)
  559. self.assertEqual(query_page.final_requests, 0)
  560. self.assertEqual(book_page.guard_final_count, 0)
  561. self.assertEqual(book_page.clicks, 1)
  562. self.assertEqual(query_page.listen.stops, len(query_page.listen.starts))
  563. self.assertEqual(book_page.listen.stops, book_page.listen.starts)
  564. applicant.query.assert_not_called()
  565. def test_real_entry_runs_flow_and_keeps_book_result_unsuccessful(self):
  566. page = FlowPage()
  567. plugin, _, trigger = prepared_plugin(page)
  568. inputs = {"username": "applicant@example.test", "expected_start_date": "2026-10-13",
  569. "expected_end_date": "2026-10-13"}
  570. original = copy.deepcopy(inputs)
  571. with browser_navigation(page):
  572. result, approval = book_with_approval(plugin, trigger, inputs)
  573. self.assertFalse(result.success)
  574. self.assertEqual(result.label, BOOKING_CALENDAR_PREFINAL_STOP_LABEL)
  575. self.assertEqual((result.urn, result.book_date, result.book_time, result.account), ("", "", "", ""))
  576. self.assertEqual(approval.candidate.day, date(2026, 10, 13))
  577. self.assertNotIn("80000113", str(plugin.logger.call_args_list))
  578. self.assertNotIn("applicant@example.test", str(plugin.logger.call_args_list))
  579. self.assertEqual(inputs, original)
  580. plugin.query.assert_not_called()
  581. def test_entry_signal_date_does_not_override_earlier_applicant_inventory(self):
  582. page = FlowPage([month("2026-09", {1: 1}), month("2026-10", {13: 1})])
  583. plugin, _, trigger = prepared_plugin(page)
  584. trigger.earliest_date = datetime(2026, 10, 13)
  585. trigger.availability = [DateAvailability(date=datetime(2026, 10, 13),
  586. times=[TimeSlot(time="01:23", label="stale-query-slot")])]
  587. with browser_navigation(page):
  588. result, approval = book_with_approval(
  589. plugin, trigger, {"username": "applicant@example.test"},
  590. )
  591. self.assertEqual(result.label, BOOKING_CALENDAR_PREFINAL_STOP_LABEL)
  592. self.assertEqual(approval.candidate.day, date(2026, 9, 1))
  593. self.assertEqual(approval.candidate.time_label, "10:05 - 11:05")
  594. self.assertEqual(page.refreshes, 1)
  595. self.assertEqual(page.month_clicks, 0)
  596. def test_query_preparation_cannot_be_converted_into_book_preparation(self):
  597. page = FlowPage()
  598. plugin, route, trigger = prepared_plugin(page)
  599. plugin._reset_calendar_state()
  600. plugin._record_calendar_prepared_route(route, role="query")
  601. with self.assertRaises(BizLogicError):
  602. plugin._record_calendar_prepared_route(route, role="book")
  603. with self.assertRaises(BizLogicError):
  604. plugin.book(trigger, {"username": "applicant@example.test"})
  605. self.assertEqual(page.refreshes, 0)
  606. def test_url_alone_is_not_a_book_preparation_proof(self):
  607. page = FlowPage()
  608. plugin, _, trigger = prepared_plugin(page)
  609. plugin._reset_calendar_state()
  610. plugin._enter_service = Mock(side_effect=BizLogicError("fresh preparation required"))
  611. with self.assertRaises(BizLogicError):
  612. plugin.book(trigger, {"username": "applicant@example.test"})
  613. plugin._enter_service.assert_called_once()
  614. self.assertEqual(page.refreshes, 0)
  615. plugin.query.assert_not_called()
  616. def test_missing_or_different_applicant_is_rejected(self):
  617. for inputs in (None, {}, {"username": "other@example.test"}):
  618. with self.subTest(inputs=inputs):
  619. page = FlowPage()
  620. plugin, _, trigger = prepared_plugin(page)
  621. with self.assertRaises(BizLogicError):
  622. plugin.book(trigger, inputs)
  623. self.assertEqual(page.refreshes, 0)
  624. def test_changed_account_page_login_or_route_is_rejected(self):
  625. mutations = [
  626. lambda p: setattr(p.config.account, "username", "other@example.test"),
  627. lambda p: setattr(p, "page", FlowPage()),
  628. lambda p: setattr(p, "session_create_time", 222.0),
  629. lambda p: setattr(p.page, "tab_id", "another-tab"),
  630. lambda p: p.free_config["apt_configs"]["slot.example.it.tourist"].update(service_id=9002),
  631. lambda p: p.free_config.update(final_submit_enabled=True),
  632. lambda p: setattr(p.page, "service", "another-runtime"),
  633. ]
  634. for mutation in mutations:
  635. with self.subTest(mutation=mutations.index(mutation)):
  636. page = FlowPage()
  637. plugin, _, trigger = prepared_plugin(page)
  638. mutation(plugin)
  639. with self.assertRaises(BizLogicError):
  640. plugin.book(trigger, {"username": "applicant@example.test"})
  641. self.assertEqual(page.refreshes, 0)
  642. def test_preparation_from_another_page_is_rejected(self):
  643. first, _, _ = prepared_plugin(FlowPage())
  644. second, _, trigger = prepared_plugin(FlowPage())
  645. second._prepared_calendar = first._prepared_calendar
  646. with self.assertRaises(BizLogicError):
  647. second.book(trigger, {"username": "applicant@example.test"})
  648. def test_second_book_call_rechecks_current_inventory(self):
  649. page = FlowPage()
  650. plugin, _, trigger = prepared_plugin(page)
  651. with browser_navigation(page):
  652. first, first_approval = book_with_approval(
  653. plugin, trigger, {"username": "applicant@example.test"},
  654. )
  655. second, second_approval = book_with_approval(
  656. plugin, trigger, {"username": "applicant@example.test"},
  657. )
  658. self.assertEqual(first.label, BOOKING_CALENDAR_PREFINAL_STOP_LABEL)
  659. self.assertEqual(second.label, BOOKING_CALENDAR_PREFINAL_STOP_LABEL)
  660. self.assertEqual(first_approval.candidate.day, second_approval.candidate.day)
  661. self.assertEqual(first_approval.candidate.time_label, second_approval.candidate.time_label)
  662. self.assertEqual(page.refreshes, 2)
  663. self.assertEqual(page.clicks, 2)
  664. def test_no_inventory_within_preferences_is_not_reported_as_success(self):
  665. page = FlowPage([month("2026-10", {13: 0})])
  666. plugin, _, trigger = prepared_plugin(page)
  667. with browser_navigation(page):
  668. result, approval = book_with_approval(
  669. plugin, trigger,
  670. {"username": "applicant@example.test", "expected_end_date": "2026-10-31"},
  671. )
  672. self.assertFalse(result.success)
  673. self.assertEqual(result.label, BOOKING_RECHECK_NONE_AVAILABLE_LABEL)
  674. self.assertIsNone(approval)
  675. def test_mid_capture_account_change_invalidates_preparation(self):
  676. page = FlowPage()
  677. plugin, _, trigger = prepared_plugin(page)
  678. page.wait_hook = lambda: setattr(plugin.config.account, "username", "other@example.test")
  679. with browser_navigation(page), self.assertRaises(BizLogicError):
  680. plugin.book(trigger, {"username": "applicant@example.test"})
  681. self.assertIsNone(plugin._prepared_calendar)
  682. self.assertEqual(page.clicks, 0)
  683. def test_account_change_during_candidate_dom_read_blocks_the_click(self):
  684. page = FlowPage()
  685. plugin, _, trigger = prepared_plugin(page)
  686. original = page.run_js
  687. def changed_account(script, *args):
  688. raw = original(script, *args)
  689. if script == SLOT_SELECTION_SCRIPT and args[-1] is False:
  690. plugin.config.account.username = "other@example.test"
  691. return raw
  692. page.run_js = changed_account
  693. with browser_navigation(page), self.assertRaises(BizLogicError):
  694. plugin.book(trigger, {"username": "applicant@example.test"})
  695. self.assertIsNone(plugin._prepared_calendar)
  696. self.assertEqual(page.clicks, 0)
  697. self.assertEqual(page.date_clicks, [])
  698. def test_lifecycle_operations_clear_book_preparation(self):
  699. for action in ("config", "login", "cleanup"):
  700. with self.subTest(action=action):
  701. plugin, _, _ = prepared_plugin(FlowPage())
  702. if action == "config":
  703. plugin.set_config(plugin.config)
  704. elif action == "login":
  705. with patch("plugins.ita_plugin.init_chromium_options", side_effect=RuntimeError("offline stop")):
  706. with self.assertRaises(RuntimeError):
  707. plugin.create_session()
  708. else:
  709. plugin.cleanup()
  710. self.assertIsNone(plugin._prepared_calendar)
  711. self.assertFalse(hasattr(plugin, "last_booking_precommit"))
  712. def test_http_auth_and_rate_limit_use_existing_framework_errors(self):
  713. for status, error in ((401, SessionExpiredOrInvalidError), (429, RateLimiteddError)):
  714. with self.subTest(status=status):
  715. page = FlowPage()
  716. plugin, _, trigger = prepared_plugin(page)
  717. page.request_mutator = lambda p: setattr(p.response, "status", status)
  718. with browser_navigation(page), self.assertRaises(error):
  719. plugin.book(trigger, {"username": "applicant@example.test"})
  720. self.assertIsNone(plugin._prepared_calendar)
  721. self.assertEqual(page.clicks, 0)
  722. def test_provider_failure_at_entry_is_sanitized_and_invalidates_proof(self):
  723. page = FlowPage()
  724. plugin, _, trigger = prepared_plugin(page)
  725. page.browser_error = "secret-provider-body"
  726. try:
  727. plugin.book(trigger, {"username": "applicant@example.test"})
  728. except BizLogicError:
  729. self.assertNotIn("secret-provider-body", traceback.format_exc())
  730. else:
  731. self.fail("Provider failure was accepted")
  732. self.assertIsNone(plugin._prepared_calendar)
  733. def test_two_route_keys_share_the_same_calendar_flow(self):
  734. for key in ("slot.hkg.it.tourist", "slot.dub.it.tourist"):
  735. with self.subTest(key=key):
  736. page = FlowPage()
  737. plugin, _, trigger = prepared_plugin(page, routing_key=key)
  738. with browser_navigation(page):
  739. result = plugin.book(trigger, {"username": "applicant@example.test"})
  740. self.assertEqual(result.label, BOOKING_CALENDAR_PREFINAL_STOP_LABEL)
  741. def test_query_mode_does_not_drive_the_prepared_book_branch(self):
  742. page = FlowPage()
  743. plugin, _, trigger = prepared_plugin(page)
  744. plugin.free_config["query_mode"] = "calendar"
  745. with browser_navigation(page):
  746. result = plugin.book(trigger, {"username": "applicant@example.test"})
  747. self.assertEqual(result.label, BOOKING_CALENDAR_PREFINAL_STOP_LABEL)
  748. plugin.query.assert_not_called()
  749. def test_final_request_observation_rejects_instead_of_reporting_precommit(self):
  750. page = FlowPage()
  751. plugin, _, trigger = prepared_plugin(page)
  752. page.guard_final_count = 1
  753. with browser_navigation(page), self.assertRaises(BizLogicError):
  754. plugin.book(trigger, {"username": "applicant@example.test"})
  755. self.assertEqual(page.refreshes, 0)
  756. self.assertEqual(page.clicks, 0)
  757. DATE_JS_HARNESS = r"""
  758. const vm = require('node:vm');
  759. const {source, mode} = JSON.parse(require('node:fs').readFileSync(0, 'utf8'));
  760. let clicks = 0, finalClicks = 0;
  761. const zeroSize = mode.startsWith('zero_size') || mode === 'selected_zero_size';
  762. function node(day) {
  763. const classes = new Set(['input-async-abilitato']);
  764. return {dataset: {date: day}, isConnected: true,
  765. classList: {contains: c => classes.has(c), add: c => classes.add(c)},
  766. hasAttribute: () => false, getAttribute: () => null,
  767. getBoundingClientRect: () => ({width: zeroSize || mode === 'zero_width' ? 0 : 90,
  768. height: zeroSize || mode === 'zero_height' ? 0 : 30, left: 3000}),
  769. };
  770. }
  771. const old = node('2026-10-01'), link = node('2026-10-13');
  772. let selected = ['already_selected', 'selected_zero_size'].includes(mode) ? link : old;
  773. const content = node(selected.dataset.date);
  774. link.click = () => {clicks++; selected = link; content.dataset.date = link.dataset.date;};
  775. if (['disabled', 'zero_size_disabled'].includes(mode)) link.classList.add('input-async-disabilitato');
  776. if (mode === 'negative') link.classList.add('notAvailableDay');
  777. const final = {disabled: mode !== 'unguarded', dataset: {coordinateFinalGuard: 'enabled'}, click: () => finalClicks++};
  778. const document = {
  779. querySelectorAll(q) {
  780. if (q === '#idServizio') return [{value: mode === 'wrong_service' ? 'wrong' : '7002'}];
  781. if (q === '#btnPrenotaNoOtp') return [final];
  782. if (q === '.events a[data-date]') return mode === 'duplicate' ? [old, link, link] : [old, link];
  783. if (q === '.events a.selected') return [selected];
  784. if (q === '.events-content li.selected') return [content];
  785. throw Error('Unexpected selector');
  786. },
  787. querySelector(q) {if (q === '.selected') return selected; throw Error('Unexpected selector');},
  788. };
  789. const window = {
  790. location: {origin: mode === 'wrong_origin' ? 'https://other.example.test' : 'https://prenotami.esteri.it', pathname: '/BookingCalendar'},
  791. getComputedStyle: element => ({
  792. display: ['hidden', 'zero_size_hidden'].includes(mode) ? 'none' : 'block',
  793. visibility: 'visible', opacity: '1',
  794. pointerEvents: mode === 'zero_size_pointer_blocked' ||
  795. (mode === 'selected_zero_size' && element === selected) ? 'none' : 'auto',
  796. }),
  797. };
  798. const run = click => vm.runInNewContext('(function(){' + source + '\n}).apply(null, args)',
  799. {document, window, args: ['7002', '2026-10-13', click]}, {timeout: 1000});
  800. const before = run(false), acted = run(true), after = run(false);
  801. process.stdout.write(JSON.stringify({before, acted, after, clicks, finalClicks}));
  802. """
  803. @unittest.skipUnless(shutil.which("node"), "Node is required for the native-date script contract")
  804. class BookDateJavaScriptTests(unittest.TestCase):
  805. def run_case(self, mode):
  806. completed = subprocess.run([shutil.which("node"), "-e", DATE_JS_HARNESS],
  807. input=json.dumps({"source": DATE_SELECTION_SCRIPT, "mode": mode}),
  808. text=True, capture_output=True, timeout=10, check=True)
  809. return json.loads(completed.stdout)
  810. def test_native_date_selection_can_target_offscreen_timeline_and_never_final(self):
  811. result = self.run_case("positive")
  812. self.assertEqual(result["clicks"], 1)
  813. self.assertTrue(result["after"]["selected"])
  814. self.assertEqual(result["finalClicks"], 0)
  815. def test_already_selected_date_is_not_clicked_again(self):
  816. result = self.run_case("already_selected")
  817. self.assertEqual(result["clicks"], 0)
  818. self.assertTrue(result["before"]["selected"])
  819. def test_zero_size_enabled_dates_follow_native_click_and_readback(self):
  820. for mode in ("zero_width", "zero_height", "zero_size"):
  821. with self.subTest(mode=mode):
  822. result = self.run_case(mode)
  823. self.assertTrue(result["before"]["candidateReady"])
  824. self.assertEqual(result["clicks"], 1)
  825. self.assertTrue(result["after"]["selected"])
  826. self.assertEqual(result["finalClicks"], 0)
  827. def test_selected_zero_size_pointer_blocked_date_is_not_reclicked(self):
  828. result = self.run_case("selected_zero_size")
  829. self.assertTrue(result["before"]["selected"])
  830. self.assertFalse(result["before"]["candidateReady"])
  831. self.assertEqual(result["clicks"], 0)
  832. self.assertEqual(result["finalClicks"], 0)
  833. def test_guarded_native_date_action_rejects_unsafe_controls(self):
  834. for mode in ("disabled", "negative", "unguarded", "wrong_service", "wrong_origin", "duplicate", "hidden",
  835. "zero_size_disabled", "zero_size_hidden", "zero_size_pointer_blocked"):
  836. with self.subTest(mode=mode):
  837. result = self.run_case(mode)
  838. self.assertEqual(result["clicks"], 0)
  839. self.assertEqual(result["finalClicks"], 0)
  840. if __name__ == "__main__":
  841. unittest.main()