test_ita_final_read_port.py 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310
  1. """Real read-port orchestration + receipt parsers, offline browser only."""
  2. import copy
  3. import ast
  4. import traceback
  5. import unittest
  6. from dataclasses import replace
  7. from pathlib import Path
  8. from types import MethodType, SimpleNamespace
  9. from unittest.mock import Mock, patch
  10. from plugins.ita_plugin import FinalBookingAttempt, FinalBookingError, FinalOutcomeUnknown, SubmissionSignal
  11. from plugins.ita_plugin import FinalReceiptReadPort, LIST_URL, MAX_DETAIL_READS
  12. from plugins.ita_plugin import ItaPlugin
  13. from plugins.ita_plugin import ItaCapability, ItaRouteConfig, CalendarScanConfig
  14. from plugins.ita_plugin import DETAIL_READ_SCRIPT, LIST_READ_SCRIPT
  15. from test.test_ita_booking_final import target
  16. from test.test_ita_reservation import detail, listing
  17. class ReceiptTab:
  18. def __init__(self, browser, index):
  19. self.browser = browser
  20. self.tab_id = f"receipt-{index}"
  21. self.url = "about:blank"
  22. self.urls = []
  23. self.list_visits = 0
  24. self.close = Mock(side_effect=lambda: browser.on_close(self))
  25. def get(self, url, *, retry, timeout):
  26. assert retry == 0 and timeout == 30
  27. self.urls.append(url)
  28. self.url = url
  29. self.list_visits += url == LIST_URL
  30. self.browser.on_get(self)
  31. return True
  32. def run_js(self, script):
  33. if script == LIST_READ_SCRIPT:
  34. raw = self.browser.after if self.list_visits > 1 and self.browser.after else self.browser.raw
  35. return copy.deepcopy(raw)
  36. if script == DETAIL_READ_SCRIPT:
  37. return copy.deepcopy(self.browser.receipts.get(self.url, self.browser.receipt))
  38. raise AssertionError("Unexpected non-receipt browser action")
  39. class Browser:
  40. def __init__(self):
  41. self.id = "synthetic-browser"
  42. self.raw, self.receipt = listing(), detail()
  43. self.receipts = {}
  44. self.after = None
  45. self.pages = []
  46. self.on_get = lambda page: None
  47. self.on_close = lambda page: None
  48. self.new_tab = Mock(side_effect=self.open_tab)
  49. def open_tab(self, *, background, new_context):
  50. assert background is True and new_context is False
  51. tab = ReceiptTab(self, len(self.pages))
  52. self.pages.append(tab)
  53. return tab
  54. class FinalReadPortTests(unittest.TestCase):
  55. def setUp(self):
  56. self.sleeper = patch("plugins.ita_plugin.time.sleep").start()
  57. self.addCleanup(patch.stopall)
  58. self.browser = Browser()
  59. self.main = SimpleNamespace(browser=self.browser, tab_id="calendar-tab",
  60. url="https://prenotami.esteri.it/BookingCalendar")
  61. self.main.get = Mock(side_effect=AssertionError("Calendar navigation forbidden"))
  62. self.main.close = Mock(side_effect=AssertionError("Calendar close forbidden"))
  63. self.main.run_js = Mock(side_effect=AssertionError("Calendar mutation forbidden"))
  64. approval = target().approval
  65. self.route = ItaRouteConfig("slot.fixture.it.tourist", 7001,
  66. ItaCapability.SINGLE_SCHENGEN_TOURISM, CalendarScanConfig(3))
  67. self.plugin = SimpleNamespace(page=self.main, session_create_time=1, is_healthy=True,
  68. config=SimpleNamespace(account=SimpleNamespace(username="Applicant@example.test")),
  69. free_config={"final_submit_enabled": False},
  70. last_booking_precommit=approval, _calendar_query_route_key=None)
  71. self.plugin._calendar_book_prepared_context = (
  72. id(self.plugin), self.main, "applicant@example.test", 1, self.route, "7001", self.main.tab_id)
  73. self.plugin._resolve_route = lambda apt: self.route
  74. self.plugin._book_final_configuration_valid = MethodType(ItaPlugin._book_final_configuration_valid, self.plugin)
  75. self.plugin._calendar_book_context_matches = MethodType(ItaPlugin._calendar_book_context_matches, self.plugin)
  76. self.port = FinalReceiptReadPort(self.plugin, self.route)
  77. def test_constructor_never_opens_or_changes_browser(self):
  78. self.browser.new_tab.assert_not_called()
  79. self.assertTrue(self.port.session_is_current())
  80. self.assertEqual(self.port.target.applicant, "applicant@example.test")
  81. self.assertEqual(self.port.target.service_id, "7001")
  82. def test_real_parsers_create_bound_cancelled_baseline_without_invented_ids(self):
  83. snapshot = self.port()
  84. self.assertTrue(snapshot.complete)
  85. self.assertEqual(snapshot.applicant, self.port.target.applicant)
  86. self.assertEqual(snapshot.session_key, self.port.target.session_key)
  87. row, = snapshot.records
  88. self.assertIsNone(row.service_id)
  89. self.assertIsNone(row.time_label)
  90. self.assertEqual(row.appointment_time, "10:25")
  91. self.assertRegex(row.receipt_fingerprint, r"^[0-9a-f]{64}$")
  92. self.assertNotIn("SYNTHETIC-REFERENCE", repr(snapshot))
  93. self.assertEqual(self.browser.pages[0].urls, [LIST_URL,
  94. listing()["tables"][0]["rows"][0]["detailUrl"], LIST_URL])
  95. self.browser.pages[0].close.assert_called_once()
  96. self.main.get.assert_not_called()
  97. self.main.close.assert_not_called()
  98. self.main.run_js.assert_not_called()
  99. def test_no_query_preparation_can_be_used(self):
  100. self.plugin._calendar_query_route_key = "slot.fixture.it.tourist"
  101. with self.assertRaises(FinalBookingError):
  102. FinalReceiptReadPort(self.plugin, self.route)
  103. self.browser.new_tab.assert_not_called()
  104. def test_capture_requires_precommit_and_final_disabled(self):
  105. for change in (lambda: setattr(self.plugin, "last_booking_precommit", None),
  106. lambda: self.plugin.free_config.update(final_submit_enabled=True)):
  107. self.setUp()
  108. change()
  109. with self.assertRaises(FinalBookingError):
  110. FinalReceiptReadPort(self.plugin, self.route)
  111. def test_each_binding_change_rejects_before_opening_a_tab(self):
  112. changes = (
  113. lambda: setattr(self.plugin.config.account, "username", "OTHER"),
  114. lambda: setattr(self.plugin, "session_create_time", 2),
  115. lambda: setattr(self.main, "tab_id", "OTHER"),
  116. lambda: setattr(self.browser, "id", "OTHER"),
  117. lambda: setattr(self.plugin, "is_healthy", False),
  118. lambda: setattr(self.plugin, "last_booking_precommit", replace(self.port.target.approval)),
  119. lambda: setattr(self, "route", replace(self.route, service_id=8001)),
  120. )
  121. for change in changes:
  122. self.setUp()
  123. change()
  124. with self.assertRaises(FinalBookingError):
  125. self.port()
  126. self.browser.new_tab.assert_not_called()
  127. def test_context_change_during_read_closes_only_owned_tab(self):
  128. self.browser.on_get = lambda page: setattr(self.plugin, "session_create_time", 2)
  129. with self.assertRaises(FinalBookingError):
  130. self.port()
  131. self.browser.pages[0].close.assert_called_once()
  132. self.main.close.assert_not_called()
  133. def test_factory_returning_calendar_or_foreign_tab_is_not_owned(self):
  134. for candidate in (self.main, SimpleNamespace(browser=Browser(), tab_id="foreign", close=Mock())):
  135. self.browser.new_tab.side_effect = None
  136. self.browser.new_tab.return_value = candidate
  137. with self.assertRaises(FinalBookingError):
  138. self.port()
  139. candidate.close.assert_not_called()
  140. def test_wrong_origin_login_redirect_or_detail_identity_rejects(self):
  141. self.browser.on_get = lambda page: setattr(page, "url", "https://iam.esteri.it/signin/")
  142. with self.assertRaises(FinalBookingError):
  143. self.port()
  144. self.browser.pages[0].close.assert_called_once()
  145. self.browser.on_get = lambda page: None
  146. self.browser.receipt["fields"]["Codice Prenotazione"] = "OTHER"
  147. with self.assertRaises(FinalBookingError):
  148. self.port()
  149. self.browser.pages[-1].close.assert_called_once()
  150. def test_list_change_during_read_rejects(self):
  151. self.browser.after = listing()
  152. self.browser.after["tables"][0]["rows"][0]["time"] = "10:26"
  153. with self.assertRaises(FinalBookingError):
  154. self.port()
  155. def test_unknown_status_and_code_do_not_become_active_or_cancelled(self):
  156. self.browser.raw["tables"][0]["rows"][0]["status"] = "Confermata"
  157. with self.assertRaises(FinalBookingError):
  158. self.port()
  159. self.assertEqual(self.browser.pages[0].urls, [LIST_URL])
  160. self.browser.raw = listing()
  161. self.browser.receipt["statusCode"] = "1"
  162. with self.assertRaises(FinalBookingError):
  163. self.port()
  164. def test_cancelled_display_metadata_changes_are_preserved_in_fingerprint(self):
  165. first = self.port()
  166. self.browser.receipt["fields"]["Tipo Prenotazione"] = "Changed type"
  167. second = self.port()
  168. self.assertNotEqual(first.records[0], second.records[0])
  169. self.assertNotEqual(first.records[0].receipt_fingerprint, second.records[0].receipt_fingerprint)
  170. def test_detail_limit_never_produces_partial_snapshot(self):
  171. main = self.browser.raw["tables"][0]
  172. base = main["rows"][0]
  173. count = MAX_DETAIL_READS + 1
  174. main["rows"] = [{**base, "reference": f"REF-{i}",
  175. "detailUrl": f"https://prenotami.esteri.it/ReservationDetail/Index/{i}"} for i in range(count)]
  176. main.update(count=count)
  177. main["info"].update(recordsTotal=count, recordsDisplay=count, end=10, pages=3)
  178. with self.assertRaises(FinalBookingError):
  179. self.port()
  180. self.assertEqual(self.browser.pages[0].urls, [LIST_URL])
  181. def test_empty_verified_history_can_be_read(self):
  182. table = self.browser.raw["tables"][0]
  183. table.update(count=0, rows=[])
  184. table["info"].update(recordsTotal=0, recordsDisplay=0, end=0, pages=0)
  185. self.assertEqual(self.port().records, ())
  186. self.assertEqual(self.browser.pages[0].urls, [LIST_URL, LIST_URL])
  187. def test_cleanup_failure_poisoned_port_cannot_be_reused(self):
  188. def bad_close(page):
  189. raise RuntimeError("PRIVATE-CONTENT")
  190. self.browser.on_close = bad_close
  191. with self.assertRaises(FinalBookingError) as caught:
  192. self.port()
  193. self.assertNotIn("PRIVATE", "".join(traceback.format_exception(caught.exception)))
  194. self.assertFalse(self.port.session_is_current())
  195. with self.assertRaises(FinalBookingError):
  196. self.port()
  197. self.assertEqual(self.browser.new_tab.call_count, 1)
  198. def test_error_or_keyboard_interrupt_always_closes_owned_tab(self):
  199. for error in (RuntimeError("PRIVATE-CONTENT"), KeyboardInterrupt()):
  200. self.setUp()
  201. self.browser.on_get = Mock(side_effect=error)
  202. with self.assertRaises((FinalBookingError, KeyboardInterrupt)):
  203. self.port()
  204. self.browser.pages[0].close.assert_called_once()
  205. def test_changed_calendar_during_cleanup_cannot_return_snapshot(self):
  206. self.browser.on_close = lambda page: setattr(self.main, "url", "https://prenotami.esteri.it/UserArea")
  207. with self.assertRaises(FinalBookingError):
  208. self.port()
  209. def test_observer_brackets_navigation_and_finishes_before_owned_close(self):
  210. events = []
  211. def observe(page):
  212. self.assertEqual(page.url, "about:blank")
  213. events.append("start")
  214. return lambda: events.append("finish")
  215. self.browser.on_get = lambda page: events.append("get")
  216. self.browser.on_close = lambda page: events.append("close")
  217. port = FinalReceiptReadPort(self.plugin, self.route, observe_tab=observe)
  218. port()
  219. self.assertEqual(events, ["start", "get", "get", "get", "finish", "close"])
  220. def test_observer_failure_or_interrupt_closes_tab_and_releases_lock(self):
  221. for error in (RuntimeError("PRIVATE-CONTENT"), KeyboardInterrupt()):
  222. self.setUp()
  223. finish = Mock(side_effect=error)
  224. port = FinalReceiptReadPort(self.plugin, self.route, observe_tab=lambda page: finish)
  225. with self.assertRaises((FinalBookingError, KeyboardInterrupt)):
  226. port()
  227. self.browser.pages[0].close.assert_called_once()
  228. self.assertFalse(port.session_is_current())
  229. self.assertFalse(port._lock.locked())
  230. def test_read_port_has_no_booking_or_cookie_operations(self):
  231. from test.ita_source_sections import section
  232. tree = ast.parse(section("final_read_port"))
  233. for node in ast.walk(tree):
  234. if isinstance(node, ast.Call) and isinstance(node.func, ast.Attribute):
  235. self.assertNotIn(node.func.attr, {"click", "submit", "input", "book", "query", "cookies", "quit"})
  236. def test_read_port_composes_with_final_core_without_retries(self):
  237. submit = Mock(return_value=SubmissionSignal.REJECTED)
  238. attempt = FinalBookingAttempt(self.port.target, read_reservations=self.port,
  239. submit_native=submit, session_is_current=self.port.session_is_current)
  240. with self.assertRaises(FinalBookingError):
  241. attempt.execute()
  242. submit.assert_not_called()
  243. result = attempt.execute(enabled=True) # Explicit offline double; no native submit.
  244. self.assertFalse(result.success)
  245. self.assertEqual(attempt.state, "rejected")
  246. submit.assert_called_once()
  247. with self.assertRaises(FinalBookingError):
  248. attempt.execute(enabled=True)
  249. def test_new_unverified_live_receipt_leaves_outcome_unknown_and_reconcile_only(self):
  250. def submitted():
  251. self.browser.raw["tables"][0]["rows"][0]["status"] = "Confermata"
  252. return SubmissionSignal.ACCEPTED
  253. submit = Mock(side_effect=submitted)
  254. attempt = FinalBookingAttempt(self.port.target, read_reservations=self.port,
  255. submit_native=submit, session_is_current=self.port.session_is_current)
  256. with self.assertRaises(FinalOutcomeUnknown):
  257. attempt.execute(enabled=True)
  258. with self.assertRaises(FinalOutcomeUnknown):
  259. attempt.reconcile()
  260. with self.assertRaises(FinalBookingError):
  261. attempt.execute(enabled=True)
  262. submit.assert_called_once()
  263. self.assertEqual(attempt.state, "unknown")
  264. def test_cancelled_detail_metadata_change_after_write_cannot_be_rejected_as_no_change(self):
  265. def submitted():
  266. self.browser.receipt["fields"]["Tipo Prenotazione"] = "Changed type"
  267. return SubmissionSignal.REJECTED
  268. attempt = FinalBookingAttempt(self.port.target, read_reservations=self.port,
  269. submit_native=submitted, session_is_current=self.port.session_is_current)
  270. with self.assertRaises(FinalOutcomeUnknown):
  271. attempt.execute(enabled=True)
  272. if __name__ == "__main__":
  273. unittest.main()