| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310 |
- import ast
- import io
- import json
- import subprocess
- import sys
- import tempfile
- import unittest
- from contextlib import redirect_stderr, redirect_stdout
- from pathlib import Path
- import requests
- from tools.add_ita_query_account import (
- ACCOUNT_POOL,
- ACCOUNT_UPLOAD_URL,
- SERVICE_ID,
- run_account_upload,
- )
- class FakeResponse:
- def __init__(self, *, status_code=200, body=None, json_error=None):
- self.status_code = status_code
- self.body = body if body is not None else {"code": 0, "data": {"id": 42}}
- self.json_error = json_error
- def json(self):
- if self.json_error is not None:
- raise self.json_error
- return self.body
- class FakeSession:
- def __init__(self, *, response=None, error=None):
- self.response = response or FakeResponse()
- self.error = error
- self.calls = []
- self.trust_env = True
- def post(self, url, **kwargs):
- self.calls.append((url, kwargs))
- if self.error is not None:
- raise self.error
- return self.response
- class AddItaQueryAccountTests(unittest.TestCase):
- ENV = {
- "ITA_QUERY_USERNAME": "authorized-query@example.test",
- "ITA_QUERY_PASSWORD": "offline-password",
- "VS_ACCOUNT_UPLOAD_TOKEN": "offline-api-token",
- }
- @staticmethod
- def _run(*, env=None, apply=False, config_path=None, session=None):
- stdout = io.StringIO()
- stderr = io.StringIO()
- with redirect_stdout(stdout), redirect_stderr(stderr):
- exit_code = run_account_upload(
- env or {},
- apply=apply,
- non_interactive=True,
- config_path=config_path,
- session=session,
- )
- return exit_code, stdout.getvalue(), stderr.getvalue()
- def test_default_preflight_sends_no_request_and_needs_no_credentials(self):
- session = FakeSession(error=AssertionError("post must not be called"))
- exit_code, stdout, stderr = self._run(session=session)
- self.assertEqual(exit_code, 0)
- self.assertEqual(session.calls, [])
- self.assertIn(
- "ITA_ACCOUNT_UPLOAD_PREFLIGHT_OK "
- f"pool={ACCOUNT_POOL} service_id={SERVICE_ID} request_sent=false",
- stdout,
- )
- self.assertEqual(stderr, "")
- def test_cli_default_dry_run_starts_from_the_repository_root(self):
- repo_root = Path(__file__).resolve().parents[2]
- completed = subprocess.run(
- [sys.executable, str(repo_root / "tools" / "add_ita_query_account.py")],
- cwd=repo_root,
- check=False,
- capture_output=True,
- text=True,
- )
- self.assertEqual(completed.returncode, 0)
- self.assertIn("request_sent=false", completed.stdout)
- self.assertEqual(completed.stderr, "")
- def test_apply_sends_exactly_one_locked_pool_request_without_logging_secrets(self):
- session = FakeSession()
- exit_code, stdout, stderr = self._run(
- env=self.ENV,
- apply=True,
- session=session,
- )
- self.assertEqual(exit_code, 0)
- self.assertEqual(len(session.calls), 1)
- url, kwargs = session.calls[0]
- self.assertEqual(url, ACCOUNT_UPLOAD_URL)
- self.assertEqual(kwargs["json"]["pool_name"], ACCOUNT_POOL)
- self.assertEqual(kwargs["json"]["username"], self.ENV["ITA_QUERY_USERNAME"])
- self.assertEqual(kwargs["json"]["password"], self.ENV["ITA_QUERY_PASSWORD"])
- self.assertEqual(kwargs["json"]["extra_data"]["service_id"], SERVICE_ID)
- self.assertEqual(kwargs["timeout"], 10)
- self.assertFalse(session.trust_env)
- self.assertIn("account_id=42 request_count=1", stdout)
- combined_output = stdout + stderr
- for secret in self.ENV.values():
- self.assertNotIn(secret, combined_output)
- def test_apply_reads_ignored_local_config_and_logs_no_secret(self):
- local_values = {
- "username": "local-authorized@example.test",
- "password": "local-password",
- "account_upload_token": "local-api-token",
- }
- session = FakeSession()
- with tempfile.TemporaryDirectory() as temp_dir:
- config_path = Path(temp_dir) / "ita_query_account.local.json"
- config_path.write_text(json.dumps(local_values), encoding="utf-8")
- config_path.chmod(0o600)
- exit_code, stdout, stderr = self._run(
- apply=True,
- config_path=config_path,
- session=session,
- )
- self.assertEqual(exit_code, 0)
- self.assertEqual(len(session.calls), 1)
- _, kwargs = session.calls[0]
- self.assertEqual(kwargs["json"]["username"], local_values["username"])
- self.assertEqual(kwargs["json"]["password"], local_values["password"])
- combined_output = stdout + stderr
- for secret in local_values.values():
- self.assertNotIn(secret, combined_output)
- def test_invalid_local_config_fails_before_request_without_content_leak(self):
- session = FakeSession(error=AssertionError("post must not be called"))
- with tempfile.TemporaryDirectory() as temp_dir:
- config_path = Path(temp_dir) / "ita_query_account.local.json"
- config_path.write_text('{"password": "private-value",', encoding="utf-8")
- config_path.chmod(0o600)
- exit_code, stdout, stderr = self._run(
- apply=True,
- config_path=config_path,
- session=session,
- )
- self.assertEqual(exit_code, 2)
- self.assertEqual(session.calls, [])
- self.assertEqual(stdout, "")
- self.assertIn("local config is invalid JSON", stderr)
- self.assertNotIn("private-value", stderr)
- def test_environment_values_override_local_config(self):
- local_values = {
- "username": "stale@example.test",
- "password": "stale-password",
- "account_upload_token": "stale-token",
- }
- session = FakeSession()
- with tempfile.TemporaryDirectory() as temp_dir:
- config_path = Path(temp_dir) / "ita_query_account.local.json"
- config_path.write_text(json.dumps(local_values), encoding="utf-8")
- config_path.chmod(0o600)
- exit_code, _, _ = self._run(
- env=self.ENV,
- apply=True,
- config_path=config_path,
- session=session,
- )
- self.assertEqual(exit_code, 0)
- _, kwargs = session.calls[0]
- self.assertEqual(kwargs["json"]["username"], self.ENV["ITA_QUERY_USERNAME"])
- self.assertEqual(kwargs["json"]["password"], self.ENV["ITA_QUERY_PASSWORD"])
- def test_missing_non_interactive_credentials_fails_before_request(self):
- session = FakeSession(error=AssertionError("post must not be called"))
- exit_code, stdout, stderr = self._run(
- apply=True,
- session=session,
- )
- self.assertEqual(exit_code, 2)
- self.assertEqual(session.calls, [])
- self.assertEqual(stdout, "")
- self.assertIn("ITA_ACCOUNT_UPLOAD_CONFIG_ERROR", stderr)
- def test_http_rejection_does_not_print_response_body_or_retry(self):
- response = FakeResponse(
- status_code=409,
- body={"message": "authorized-query@example.test already exists"},
- )
- session = FakeSession(response=response)
- exit_code, stdout, stderr = self._run(
- env=self.ENV,
- apply=True,
- session=session,
- )
- self.assertEqual(exit_code, 4)
- self.assertEqual(len(session.calls), 1)
- self.assertEqual(stdout, "")
- self.assertIn("status=409 request_count=1", stderr)
- self.assertNotIn("already exists", stderr)
- self.assertNotIn(self.ENV["ITA_QUERY_USERNAME"], stderr)
- def test_transport_error_is_uncertain_and_explicitly_forbids_blind_retry(self):
- session = FakeSession(error=requests.Timeout("sensitive request details"))
- exit_code, stdout, stderr = self._run(
- env=self.ENV,
- apply=True,
- session=session,
- )
- self.assertEqual(exit_code, 5)
- self.assertEqual(len(session.calls), 1)
- self.assertEqual(stdout, "")
- self.assertIn("ITA_ACCOUNT_UPLOAD_UNCERTAIN", stderr)
- self.assertIn("action=verify-admin-before-retry", stderr)
- self.assertNotIn("sensitive request details", stderr)
- def test_invalid_success_json_is_uncertain_not_success(self):
- session = FakeSession(
- response=FakeResponse(json_error=ValueError("secret response"))
- )
- exit_code, stdout, stderr = self._run(
- env=self.ENV,
- apply=True,
- session=session,
- )
- self.assertEqual(exit_code, 5)
- self.assertEqual(len(session.calls), 1)
- self.assertEqual(stdout, "")
- self.assertIn("type=InvalidJson", stderr)
- self.assertNotIn("secret response", stderr)
- def test_business_error_is_rejected_without_message_leak(self):
- session = FakeSession(
- response=FakeResponse(
- body={"code": 40001, "message": "private server detail"}
- )
- )
- exit_code, stdout, stderr = self._run(
- env=self.ENV,
- apply=True,
- session=session,
- )
- self.assertEqual(exit_code, 4)
- self.assertEqual(len(session.calls), 1)
- self.assertEqual(stdout, "")
- self.assertIn("status=business-error", stderr)
- self.assertNotIn("private server detail", stderr)
- def test_source_has_one_post_call_no_retry_loop_and_no_secret_cli_flags(self):
- source_path = (
- Path(__file__).resolve().parents[2]
- / "tools"
- / "add_ita_query_account.py"
- )
- source = source_path.read_text(encoding="utf-8")
- tree = ast.parse(source)
- upload_function = next(
- node
- for node in tree.body
- if isinstance(node, ast.FunctionDef)
- and node.name == "run_account_upload"
- )
- post_calls = [
- node
- for node in ast.walk(upload_function)
- if isinstance(node, ast.Call)
- and isinstance(node.func, ast.Attribute)
- and node.func.attr == "post"
- ]
- retry_loops = [
- node
- for node in ast.walk(upload_function)
- if isinstance(node, (ast.For, ast.While))
- ]
- self.assertEqual(len(post_calls), 1)
- self.assertEqual(retry_loops, [])
- self.assertNotIn("--username", source)
- self.assertNotIn("--password", source)
- self.assertNotIn("--token", source)
- if __name__ == "__main__":
- unittest.main()
|